[lexical] Chore: Fix minimatch CVE-2026-26996 in example projects#8169
Merged
thatmichael85 merged 2 commits intomainfrom Feb 26, 2026
Merged
[lexical] Chore: Fix minimatch CVE-2026-26996 in example projects#8169thatmichael85 merged 2 commits intomainfrom
thatmichael85 merged 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a security vulnerability by removing the deprecated minimatch@3.1.2 dependency from three example projects. However, there is a critical issue with the CVE identifier mentioned in the title and description.
Changes:
- Migrated
extension-vanilla-tailwindandextension-vanilla-react-plugin-hostfrom unmaintainedrollup-plugin-copytovite-plugin-static-copy - Upgraded ESLint to v10.0.2 and related packages in
extension-sveltekit-ssr-hydrationto eliminateminimatch@3.1.2 - Successfully removed all instances of
minimatch@3.1.2and replaced withminimatch@10.2.3where needed
Reviewed changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| examples/extension-vanilla-tailwind/vite.config.ts | Migrated from rollup-plugin-copy to vite-plugin-static-copy with API changes |
| examples/extension-vanilla-tailwind/package.json | Replaced rollup-plugin-copy dependency with vite-plugin-static-copy |
| examples/extension-vanilla-tailwind/pnpm-lock.yaml | Updated lockfile with new dependencies, removed minimatch entirely |
| examples/extension-vanilla-react-plugin-host/vite.config.ts | Migrated from rollup-plugin-copy to vite-plugin-static-copy with API changes |
| examples/extension-vanilla-react-plugin-host/package.json | Replaced rollup-plugin-copy dependency with vite-plugin-static-copy |
| examples/extension-vanilla-react-plugin-host/pnpm-lock.yaml | Updated lockfile with new dependencies, removed minimatch entirely |
| examples/extension-sveltekit-ssr-hydration/package.json | Upgraded ESLint to v10 and related packages |
| examples/extension-sveltekit-ssr-hydration/pnpm-lock.yaml | Updated lockfile with ESLint 10 dependencies using minimatch@10.2.3 |
Files not reviewed (3)
- examples/extension-sveltekit-ssr-hydration/pnpm-lock.yaml: Language not supported
- examples/extension-vanilla-react-plugin-host/pnpm-lock.yaml: Language not supported
- examples/extension-vanilla-tailwind/pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…8117) Fixes a HIGH severity vulnerability (GHSA-3ppc-4f35-3m26) where minimatch < 3.1.3 was present as a transitive dependency in three example projects. Rather than applying pnpm overrides as a workaround, each project was fixed by upgrading the dependency that introduced it: extension-vanilla-react-plugin-host & extension-vanilla-tailwind: - Migrated from rollup-plugin-copy (unmaintained since Sep 2023) to vite-plugin-static-copy, which uses tinyglobby instead of the deprecated glob/minimatch chain. extension-sveltekit-ssr-hydration: - Upgraded eslint ^9.22.0 -> ^10.0.0 (and related packages: @eslint/js, @eslint/compat, typescript-eslint, eslint-plugin-svelte) since ESLint 10 replaced minimatch@3.x with minimatch@^10.2.1.
e6eafa9 to
a66cc41
Compare
etrepum
approved these changes
Feb 26, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
minimatchis a glob pattern matching library used internally by tools likeglobandeslintto match file paths against patterns (e.g.**/*.js). Versions < 3.1.3 have CVE-2026-26996 (ReDoS, HIGH severity) — a crafted pattern can cause catastrophic backtracking.minimatch@3.1.2was a transitive dependency in three example projects, pulled in by other outdated packages. Rather than bumping minimatch directly, we replaced the upstream packages that depended on the vulnerable version:extension-vanilla-react-plugin-host&extension-vanilla-tailwind: Replacedrollup-plugin-copy(unmaintained since Sep 2023, depends onglob→minimatch@3.x) withvite-plugin-static-copy, which usestinyglobbyinstead of theglob/minimatchchain entirely.extension-sveltekit-ssr-hydration: Upgradedeslint^9.22.0→^10.0.0(and related packages:@eslint/js,@eslint/compat,typescript-eslint,eslint-plugin-svelte) since ESLint 9 depended onminimatch@3.xwhile ESLint 10 usesminimatch@^10.2.1.Closes #8167
Test plan
Before
minimatch@3.1.2present in all three example lockfilesAfter
minimatch@3.1.2REMOVED from all example lockfilesvite-plugin-static-copyPlayground