[lexical] Bug Fix: Maintain format when replace multiple formatted text nodes with composition text#8162
Merged
etrepum merged 2 commits intofacebook:mainfrom Feb 23, 2026
Conversation
…xt to IME composition
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
etrepum
approved these changes
Feb 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Current Behavior
A regression appeared in the scenario that #8121 addressed. When replacing multi-formatted text nodes with composition text, only the first character has formatting, and it is not applied to the subsequent characters.
In issue #8067, I implemented a fix to inherit format and style when replacing multi-formatted text nodes with plain text. However, in those changes, format and style were not inherited if the node was a composing node. As a result, they are still not correctly inherited when the node is replaced during IME composition.
In issue #8119, E2E tests were introduced to verify that multi-formatted nodes are correctly replaced by composition text. However, because the tests performed bulk insertion of the composition string, they did not cover cases where the composition is committed character-by-character.
Changes in This PR
Test plan
Before
before.mov
After
after.mov