[Breaking Change][lexical] Bug Fix: Fix --lexical-indent-base-value CSS variable override #8132
Merged
etrepum merged 3 commits intofacebook:mainfrom Feb 12, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
etrepum
reviewed
Feb 11, 2026
etrepum
reviewed
Feb 11, 2026
Collaborator
etrepum
left a comment
There was a problem hiding this comment.
This reverted the change to the CSS but now it doesn't work for a different reason, --lexical-indent-base-value is only applied to indented DOM so it will never be observed by this change to indentationBaseValue
etrepum
approved these changes
Feb 12, 2026
etrepum
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Setting the
--lexical-indent-base-valueCSS custom property is now read from the editor's root element, so it must be set there or higher (e.g.:root) in the CSS. The previous implementation that attempted to read this property from other nodes had race conditions and performance implications.Description
fixes --lexical-indent-base-value CSS variable override by reading it from the editor root element instead of detached DOM nodes, and removing element-level declarations that were shadowing :root overrides.
Closes #8095
Before
Lexical.Playground.mp4
After
Lexical.Playground.1.mp4