[lexical] Bug Fix: Refactor RootNode.__cachedText computation for coherency#8099
Merged
etrepum merged 4 commits intofacebook:mainfrom Jan 31, 2026
Merged
[lexical] Bug Fix: Refactor RootNode.__cachedText computation for coherency#8099etrepum merged 4 commits intofacebook:mainfrom
etrepum merged 4 commits intofacebook:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
etrepum
commented
Jan 30, 2026
| ); | ||
| rootNode.append(barParagraphNode, bazParagraphNode); | ||
| }, | ||
| {discrete: true}, |
Collaborator
Author
There was a problem hiding this comment.
This just makes the stack trace nicer when the invariant fails, doesn't change the nature of the test
Comment on lines
+41
to
+43
| expect(root.__cachedText).toBe( | ||
| ElementNode.prototype.getTextContent.call(root), | ||
| ); |
Collaborator
Author
There was a problem hiding this comment.
This is a cleaner way to do the rootCopy thing, assuming RootNode doesn't do any meaningful changes to its implementation of getTextContent
| export interface LexicalPrivateDOM { | ||
| __lexicalTextContent?: string | undefined | null; | ||
| __lexicalLineBreak?: HTMLBRElement | HTMLImageElement | undefined | null; | ||
| __lexicalDirTextContent?: string | undefined | null; |
| let subTreeTextContent = ''; | ||
| let subTreeTextFormat: number | null = null; | ||
| let subTreeTextStyle: string | null = null; | ||
| let editorTextContent = ''; |
Collaborator
Author
There was a problem hiding this comment.
This is entirely redundant, subTreeTextContent does the same thing
|
|
||
| function $createChildren( | ||
| children: Array<NodeKey>, | ||
| element: ElementNode & LexicalPrivateDOM, |
Collaborator
Author
There was a problem hiding this comment.
This was a mistake, LexicalPrivateDOM is for DOM and not Lexical nodes
Comment on lines
+552
to
+557
| if ($isElementNode(prevNode)) { | ||
| invariant( | ||
| $isElementNode(nextNode), | ||
| 'Node with key %s changed from ElementNode to !ElementNode', | ||
| key, | ||
| ); |
Collaborator
Author
There was a problem hiding this comment.
Since the key must refer to the same exact class of element an invariant makes more sense
| return triggerCommandListeners(editor, command, payload); | ||
| } | ||
|
|
||
| export function $textContentRequiresDoubleLinebreakAtEnd( |
Collaborator
Author
There was a problem hiding this comment.
All use cases of this function were inlined because the isLastChild condition is known at all call sites
ivailop7
approved these changes
Jan 31, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The way that the reconciler computes
RootNode.__cachedTextwas inconsistent with the way thatElementNode.getTextContent()works. There were some cache coherency issues with the way ElementNode cached text was handled.This refactors the logic such that:
subTreeTextContentandeditorTextContentwere computed independently for no obvious reason)DOUBLE_LINE_BREAKcondition is handled when reconciling children of a node, rather than trying to append it to the cache of the ElementNode itselfCloses #8096
Test plan
All existing tests pass, and new unit tests pass.