Skip to content

[lexical][@lexical/table] Bug Fix: Fix inconsistent multi-cell selection in 2x2 tables#8081

Merged
etrepum merged 1 commit intofacebook:mainfrom
aldoprogrammer:fix/table-2x2-column-selection
Jan 20, 2026
Merged

[lexical][@lexical/table] Bug Fix: Fix inconsistent multi-cell selection in 2x2 tables#8081
etrepum merged 1 commit intofacebook:mainfrom
aldoprogrammer:fix/table-2x2-column-selection

Conversation

@aldoprogrammer
Copy link
Copy Markdown
Contributor

@aldoprogrammer aldoprogrammer commented Jan 17, 2026

Description

Fixes inconsistent table selection behavior in 2×2 tables.

When selecting cells vertically:

  • Selecting from the first column from top to bottom works as expected.
  • Selecting from the second column from top to bottom fails to select them.

This patch normalizes the selection logic so multi-cell selection behaves consistently on the second column.

PR Closes #8079 and Closes #8080

Demo

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
lexical Ready Ready Preview, Comment Jan 17, 2026 1:35am
lexical-playground Ready Ready Preview, Comment Jan 17, 2026 1:35am

Request Review

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 17, 2026
@etrepum etrepum added the extended-tests Run extended e2e tests on a PR label Jan 20, 2026
@etrepum etrepum changed the title [lexical][@lexical/table] Fix inconsistent multi-cell selection in 2x2 tables [lexical][@lexical/table] Bug Fix: Fix inconsistent multi-cell selection in 2x2 tables Jan 20, 2026
Copy link
Copy Markdown
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't seem to reproduce the original problem with chrome on macOS, do these e2e tests fail without the changes to the code?

Copy link
Copy Markdown
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can reproduce the original problem with Firefox and this PR seems to resolve it

@etrepum etrepum added this pull request to the merge queue Jan 20, 2026
Merged via the queue into facebook:main with commit 8cd2bce Jan 20, 2026
46 checks passed
@aldoprogrammer aldoprogrammer deleted the fix/table-2x2-column-selection branch January 22, 2026 23:37
@etrepum etrepum mentioned this pull request Jan 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Inconsistent column selection in tables (first cell skipped except last column) Bug: 2×2 table multi-cell selection misses last cell

2 participants