[lexical][@lexical/table] Fix Ctrl+A to select all cells in table with merged cells #8074#8076
Merged
etrepum merged 2 commits intofacebook:mainfrom Jan 15, 2026
Conversation
…nly editor content
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
etrepum
reviewed
Jan 14, 2026
| editor.registerCommand( | ||
| SELECT_ALL_COMMAND, | ||
| $tableSelectAllCommand, | ||
| COMMAND_PRIORITY_HIGH, |
Collaborator
There was a problem hiding this comment.
This should be the lowest priority that implements the desired behavior which is probably this:
Suggested change
| COMMAND_PRIORITY_HIGH, | |
| COMMAND_PRIORITY_LOW, |
| const uniqueCellKeys = new Set( | ||
| selectedNodes.map((node) => node.getKey()), | ||
| ); | ||
| const totalUniqueCells = new Set<string>(); |
Collaborator
There was a problem hiding this comment.
Generally the NodeKey type alias is used any time keys are being used, even though it is currently indistinguishable from string.
Suggested change
| const totalUniqueCells = new Set<string>(); | |
| const totalUniqueCells = new Set<NodeKey>(); |
…asing timeouts for slow operations
etrepum
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test plan
Before
Ctrl+Afails to select all cells when the table contains merged cells and is the only element in the editor. see from issue demo #8074After
Success to select all cells when the table contains merged cells and is the only element in the editor. Demo here
Closes #8074