Skip to content

[lexical-react] Chore: Expose onReposition prop on SelectionAlwaysOnDisplay#8071

Merged
takuyakanbr merged 2 commits intomainfrom
takuyakanbr/selection-on-display
Jan 15, 2026
Merged

[lexical-react] Chore: Expose onReposition prop on SelectionAlwaysOnDisplay#8071
takuyakanbr merged 2 commits intomainfrom
takuyakanbr/selection-on-display

Conversation

@takuyakanbr
Copy link
Copy Markdown
Contributor

Expose onReposition prop on LexicalSelectionAlwaysOnDisplay plugin and selectionAlwaysOnDisplay util.

I'd like to be able to customize how the persisted selections are rendered in an internal use case (custom background color based on active theme).

Test plan

pnpm run tsc
pnpm run flow

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
lexical Ready Ready Preview, Comment Jan 15, 2026 9:16am
lexical-playground Ready Ready Preview, Comment Jan 15, 2026 9:16am

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 12, 2026
@takuyakanbr takuyakanbr added the extended-tests Run extended e2e tests on a PR label Jan 12, 2026
@etrepum
Copy link
Copy Markdown
Collaborator

etrepum commented Jan 12, 2026

Approving because the incorrect flow type probably doesn't affect anyone outside of Meta and we don't dismiss reviews on update so you can fix it and merge when ready

@takuyakanbr takuyakanbr added this pull request to the merge queue Jan 15, 2026
Merged via the queue into main with commit 78f0e6d Jan 15, 2026
36 checks passed
@takuyakanbr takuyakanbr deleted the takuyakanbr/selection-on-display branch January 15, 2026 09:57
@etrepum etrepum mentioned this pull request Jan 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants