[lexical] Bug Fix: format removed on multi selection after replace#8069
Merged
etrepum merged 1 commit intofacebook:mainfrom Jan 11, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
etrepum
approved these changes
Jan 11, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Current behavior:
When a user applies formatting to first node and selects it with other nodes to replace the text, only the first inserted character retains the formatting. because insertText uses spliceText to insert the first character, it causes the selection's format state to reset. As a result, characters typed after the first one don't inherit the original formatting.
Changes in this PR:
Preserve formatting when text is spliced across multiple nodes. the selection's format don't reset after splicing, so user inputs retain the original formatting.
Closes #8067
Test plan
Before
before.mov
After
after.mov