[lexical-list] Bug Fix: Treat whitespace-only list items as empty when pressing Enter#8068
Merged
etrepum merged 7 commits intofacebook:mainfrom Jan 11, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
etrepum
approved these changes
Jan 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Current behavior:
When a list item contains only whitespace (e.g., a trailing space that was carried over when pressing Enter mid-line), pressing Enter does not exit the list. The user perceives the list item as empty and expects pressing Enter to exit the list, but because it contains an invisible space character, Lexical treats it as non-empty and creates new list items indefinitely. This can lead to a frustrating impression the automatic list behaviour is broken.
Reproduction steps:
"Some text ""Some text| "Changes in this PR:
$handleListInsertParagraph()informatList.tsto detect whitespace-only list itemsTest plan
Before
CleanShot.2026-01-08.at.11.38.25.mp4
After
CleanShot.2026-01-08.at.11.40.28.mp4
Unit tests added: