[lexical-playground]: Rearrange table columns#8063
Merged
ivailop7 merged 16 commits intofacebook:mainfrom Feb 10, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
|
Looks like this one needs new test expectations |
The column rearrangement feature adds data-drop-target-for-element attributes to header cells at runtime, which is irrelevant to content assertions and was causing 7 table E2E test failures. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
f8edddf to
b7d7fa9
Compare
Collaborator
Author
|
@etrepum this one is ready for rereview |
etrepum
approved these changes
Feb 10, 2026
Collaborator
etrepum
left a comment
There was a problem hiding this comment.
I didn't take a super close look at the code this time but it worked great when I tried it in the playground!
package.json
Outdated
Comment on lines
+212
to
+213
| "@atlaskit/drag-and-drop-indicator": "^0.11.1", | ||
| "@atlaskit/pragmatic-drag-and-drop": "^1.7.7", |
Collaborator
There was a problem hiding this comment.
I think these should go into packages/lexical-playground/package.json
Collaborator
Author
There was a problem hiding this comment.
yep, fixing this.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a drag handle button to the table hover action buttons.
Leverages the atlaskit npm packages.
Also fixes a number of FloatingUI issues.
Only works if the table does not contain any merged cells.
Screen.Recording.2026-01-04.at.23.48.44.mov