[lexical-playground]: Column Sort for Basic Table#8060
Merged
etrepum merged 6 commits intofacebook:mainfrom Jan 2, 2026
Merged
[lexical-playground]: Column Sort for Basic Table#8060etrepum merged 6 commits intofacebook:mainfrom
etrepum merged 6 commits intofacebook:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
etrepum
reviewed
Dec 30, 2025
packages/lexical-playground/src/plugins/TableHoverActionsV2Plugin/index.tsx
Outdated
Show resolved
Hide resolved
packages/lexical-playground/src/plugins/TableHoverActionsV2Plugin/index.tsx
Outdated
Show resolved
Hide resolved
packages/lexical-playground/src/plugins/TableHoverActionsV2Plugin/index.tsx
Show resolved
Hide resolved
packages/lexical-playground/src/plugins/TableHoverActionsV2Plugin/index.tsx
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
@etrepum thanks for the pointers! Addressed the comments and made it no-op when there are merged cells. I think is in a mergable state now. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add basic sorting to table columns.
Behaviour:
On mouse hover over the top row, it shows a sort button that shows a menu for Ascending or Descending sorting of the column. Upon selection it sorts the rows in the table.It excludes the header row from the sort if such is present.
The sorting is no-op when the table contains any merged cells.
Screen.Recording.2025-12-30.at.22.37.23.mov