npm -> pnpm by zurfyx · Pull Request #8035 · facebook/lexical

zurfyx · 2025-12-17T15:56:11Z

We have made the decision to migrate to PNPM. We believe Lexical can benefit from its security and performance.

This PR encapsulates the minimum viables changes to get there, which boil down to:

Replacing npm for pnpm and adjusting the syntax
Declaring phantom dependencies
Small tweaks to the CI (including an upgrade to Node 22 LTS)

Test plan:

Compare build side-by-side
Compare (Meta) WWW build side-by-side
Meta's PNPM internal deployment (D89383966)
CI passes
NPM publish (let's merge this PR first)
Updating CONTRIBUTING.md
Create new package (will be followed up separately after docs/)

vercel · 2025-12-17T15:56:17Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
lexical	Ready	Preview, Comment	Dec 21, 2025 10:11pm
lexical-playground	Ready	Preview, Comment	Dec 21, 2025 10:11pm

etrepum · 2025-12-17T17:27:10Z

.pnpmrc

@@ -0,0 +1 @@
+legacy-peer-deps=true


I don't think this is a config option at all in pnpm

etrepum

Haven't had a chance to look through all of it or try it locally yet but this is what I noticed with a quick look

etrepum · 2025-12-19T18:08:12Z

.github/workflows/call-core-tests.yml

    strategy:
      matrix:
-        node-version: [22.19.0]
+        node-version: [22.x]


Is there a strong reason to keep 22.x instead of upgrading to the active lts 24.x?

For some reason, 24.x and 25.x hang when running Playwright, which I why I intentionally put an engine restriction of < 23.0. I was thinking to look at it separately, maybe upgrading the latest Playwright version will do but there's already a lot going on in this PR

etrepum · 2025-12-19T18:12:43Z

examples/vanilla-js-plugin/package.json

+    "@lexical/clipboard": "file:../../npm/lexical-clipboard-0.39.0.tgz",
+    "@lexical/dragon": "file:../../npm/lexical-dragon-0.39.0.tgz",
+    "@lexical/extension": "file:../../npm/lexical-extension-0.39.0.tgz",
+    "@lexical/history": "file:../../npm/lexical-history-0.39.0.tgz",
+    "@lexical/html": "file:../../npm/lexical-html-0.39.0.tgz",
+    "@lexical/list": "file:../../npm/lexical-list-0.39.0.tgz",
+    "@lexical/rich-text": "file:../../npm/lexical-rich-text-0.39.0.tgz",
+    "@lexical/selection": "file:../../npm/lexical-selection-0.39.0.tgz",
+    "@lexical/table": "file:../../npm/lexical-table-0.39.0.tgz",
+    "@lexical/utils": "file:../../npm/lexical-utils-0.39.0.tgz",
    "emoji-datasource-facebook": "15.1.2",
-    "lexical": "0.39.0"
+    "lexical": "file:../../npm/lexical-0.39.0.tgz"


this looks like an accident

etrepum · 2025-12-19T18:13:23Z

examples/extension-sveltekit-ssr-hydration/package.json

    "vitest-browser-svelte": "^0.1.0"
+  },
+  "optionalDependencies": {
+    "@rollup/rollup-linux-x64-gnu": "4.6.1"


I wonder if we might want to add other platforms to this or to include @rollup/wasm-node or something

etrepum · 2025-12-19T20:46:43Z

scripts/__tests__/integration/utils.js

        async () => {
-          await withCwd(exampleDir, () => expectSuccessfulExec('npm run test'));
+          await withCwd(exampleDir, () =>
+            expectSuccessfulExec('pnpm run test'),


This is a bit inconsistent, right now everything else with examples and integration tests is run with npm and uses package-lock.json. I think it happens to work because the node_modules is set up properly but it is a bit strange

@etrepum This was actually intentional but I'm happy to do either way. My thought process is, documentation and examples are user-oriented, and folks are the most familiar with NPM. For developers in our repo, PNPM is preferable option. Would you agree with this / or do you think that these examples are more test oriented as opposed to user facing?

I think either is fine but it should be consistent, if we’re installing example with npm we should be testing the examples with npm (and making sure to handle the correct lock files). I don’t think it’s a big deal either way, the examples should still work for users with any package manager, the only difference should be whether a lockfile is used or not.

Ah yes, you're completely right, sorry I misread the code pointer

etrepum · 2025-12-19T20:48:46Z

scripts/override-react.js

  await exec(cmd);
  await exec(
-    `git checkout package-lock.json package.json packages/*/package.json`,
+    `git checkout pnpm-lock.yaml package.json packages/*/package.json`,


This might not be working correctly because the examples are still using npm and package-lock.json?

etrepum · 2025-12-19T20:54:45Z

CONTRIBUTING.md

+npm install -g pnpm
+# or if you have Node.js 16.13+
+corepack enable


I think these instructions might be a bit out of date, the latest node versions have moved corepack out of the distribution so it might be something more like

npx corepack@latest enable

etrepum · 2025-12-20T00:28:12Z

I confirmed that installing and running the unit tests & e2e tests works as expected.

After a closer look I think it's probably worth auditing each pnpm run that uses -- since those might not be correct anymore. Those exist because npm run arg --foo has npm parse the argument --foo but pnpm run arg --foo passes the argument to the script like npm run arg -- --foo which is what's wanted in 99.99% of the cases (and how npx behaves). It also gets really messy in npm when scripts invoke other scripts so you have multiple layers of --.

The solution is probably to just get rid of all the --.

thedjpetersen · 2025-12-22T01:21:58Z

Neat - curious to learn more about the advantages of PNPM

etrepum · 2025-12-22T01:29:16Z

The primary motivation for this PR is better security defaults. There are also some developer ergonomic improvements such as better script argument passing with pnpm run vs. npm run (no need for -- escaping).

pnpm

c68d689

meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 17, 2025

Fix build

784628e

vercel bot had a problem deploying to Preview – lexical-playground December 17, 2025 17:03 Failure

vercel bot had a problem deploying to Preview – lexical December 17, 2025 17:03 Failure

etrepum reviewed Dec 17, 2025

View reviewed changes

fix build

602e13e

vercel bot had a problem deploying to Preview – lexical-playground December 17, 2025 18:39 Failure

vercel bot had a problem deploying to Preview – lexical December 17, 2025 18:39 Failure

fix ci

1166f35

vercel bot had a problem deploying to Preview – lexical-playground December 17, 2025 19:04 Failure

vercel bot had a problem deploying to Preview – lexical December 17, 2025 19:04 Failure

.

5297f83

vercel bot had a problem deploying to Preview – lexical December 17, 2025 19:06 Failure

vercel bot had a problem deploying to Preview – lexical-playground December 17, 2025 19:06 Failure

more fixes

51f74cb

vercel bot had a problem deploying to Preview – lexical December 17, 2025 19:11 Failure

vercel bot had a problem deploying to Preview – lexical-playground December 17, 2025 19:11 Failure

.

989e4db

vercel bot had a problem deploying to Preview – lexical-playground December 17, 2025 19:13 Failure

vercel bot had a problem deploying to Preview – lexical December 17, 2025 19:13 Failure

.

3fad49b

vercel bot had a problem deploying to Preview – lexical-playground December 17, 2025 19:21 Failure

vercel bot had a problem deploying to Preview – lexical December 17, 2025 19:22 Failure

.

175d980

vercel bot had a problem deploying to Preview – lexical-playground December 17, 2025 19:35 Failure

vercel bot had a problem deploying to Preview – lexical December 17, 2025 19:36 Failure

.

1c49b67

vercel bot had a problem deploying to Preview – lexical-playground December 17, 2025 19:44 Failure

zurfyx added 17 commits December 18, 2025 16:14

docs

fba853f

update collab server package

fabdd0d

ywebsocket

32f3ced

.

7f73927

fix integration

ad9cdb4

some more npm

5f5ab8a

more replacements

a9b1aa3

fix integration test

04a7459

more

f38f6f5

.

ee1f476

patch --no-save thingy

74088fa

.

4365fd9

permissions

2e98323

.

ad0be80

debugging integration ci

04bf9cb

add optional dependencies to example files

2c361c9

restore jest worker logic

c044899

etrepum reviewed Dec 19, 2025

View reviewed changes

comments

622bd1b

etrepum approved these changes Dec 19, 2025

View reviewed changes

zurfyx added 5 commits December 21, 2025 16:44

example consistency

9f06a56

contributing fixes

bba06b6

redundant --

52f851f

.

625bcb0

.

cabaca3

etrepum mentioned this pull request Jan 31, 2026

v0.40.0 #8104

Merged

2wheeh mentioned this pull request Feb 24, 2026

Bug: CI fails because it can't set up Node #6463

Closed

		@@ -0,0 +1 @@
		legacy-peer-deps=true

Conversation

zurfyx commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

etrepum left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zurfyx Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

etrepum Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

etrepum commented Dec 20, 2025

Uh oh!

thedjpetersen commented Dec 22, 2025

Uh oh!

etrepum commented Dec 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zurfyx commented Dec 17, 2025 •

edited

Loading

vercel bot commented Dec 17, 2025 •

edited

Loading

zurfyx Dec 19, 2025 •

edited

Loading

etrepum Dec 20, 2025 •

edited

Loading