[lexical-yjs] Bug fix: don't rewrite unchanged non-primitive property/state values to yjs in collab v2#7990
Merged
etrepum merged 1 commit intofacebook:mainfrom Nov 14, 2025
Conversation
…y/state values to yjs in collab v2
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
etrepum
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When syncing properties/state to Yjs in collab v2, I was doing a shallow equality check on the values in Yjs and Lexical. The former however was coming from
yDomFragment.getAttributes()which may not have been reference-equal. This meant that any non-primitive values for properties or state could end up being re-written to Yjs whenever the node was dirty.This is particularly a problem when GC is disabled on the ydoc as you end up building up a lot of cruft.
The fix is to do a deep equality check, which is what the code was already doing for
equalYTypePNode, asequalAttrsis recursive.Test plan
Added unit test fails before, passes after the change.