[lexical-code] Bug fix: Add editor key in highlighted nodes cache#7970
Merged
takuyakanbr merged 1 commit intomainfrom Nov 3, 2025
Merged
[lexical-code] Bug fix: Add editor key in highlighted nodes cache#7970takuyakanbr merged 1 commit intomainfrom
takuyakanbr merged 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
etrepum
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepend editor keys when adding node keys into the
nodesCurrentlyHighlightingcache inCodeHighlighterPrism.ts, so that code highlighting does not get skipped for some editors when multiple editors on the page are initialized with the same content.Test plan
Run existing tests:
npm run test-unit LexicalCodeNode