[lexical] Bug Fix: retain selection during updates on unfocused editor#7941
Merged
etrepum merged 3 commits intofacebook:mainfrom Oct 23, 2025
Merged
[lexical] Bug Fix: retain selection during updates on unfocused editor#7941etrepum merged 3 commits intofacebook:mainfrom
etrepum merged 3 commits intofacebook:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
Found it when editor's text color was updated with debounce (so there's no associated window.event), and caret is within color picker input. |
etrepum
reviewed
Oct 22, 2025
| page, | ||
| isPlainText, | ||
| }) => { | ||
| test.skip(isPlainText); |
Collaborator
There was a problem hiding this comment.
I think this also needs to skip collab
etrepum
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There's an issue when editor loses selection state when it's blurred (DOM selection is elsewhere), and editor update is triggered without user event (so window.event is null):
https://stackblitz.com/edit/lexical-selection-retention?file=index.html
E2e test is replicating the same thing: adds content and selection state to the editor, focus into font-size input, triggers programmatic update. Selection state is lost