Skip to content

[lexical-link][lexical-code-shiki][examples] Feature: Implement mergeConfig for LinkExtension and flatten config for CodeHighlighterShikiExtension#7936

Merged
etrepum merged 4 commits intofacebook:mainfrom
etrepum:mergeConfig-link-codehighlighter
Oct 21, 2025
Merged

Conversation

@etrepum
Copy link
Copy Markdown
Collaborator

@etrepum etrepum commented Oct 20, 2025

Breaking Change

If you are using CodeHighlighterShikiExtension the configuration has changed.

Before:

configExtension(CodeHighlighterShikiExtension, {tokenizer: {...ShikiTokenizer, defaultTheme: })

After:

configExtension(CodeHighlighterShikiExtension, {defaultTheme: })

Description

  • This implements mergeConfig for LinkExtensionConfig so attributes will be merged, e.g. one configExtension can supply {target: '_blank'} and another can supply {rel: 'noopener'} and the final config will be {attributes: {rel: 'noopener', target: '_blank'}}.
  • This flattens the Tokenizer config for CodeHighlighterShikiExtension (the config itself is now the Tokenizer, rather than being nested in a tokenizer property).
  • Updates the extension-sveltekit-ssr-hydration example to combine its use of ClickableLinkExtension and its local WatchEditableExtension to disable the ClickableLinkExtension when editable

Test plan

Type checks

… LinkExtension and flatten config for CodeHighlighterShikiExtension
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 20, 2025
@vercel
Copy link
Copy Markdown

vercel bot commented Oct 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
lexical Ready Ready Preview Comment Oct 21, 2025 5:42am
lexical-playground Ready Ready Preview Comment Oct 21, 2025 5:42am

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

@etrepum etrepum added the extended-tests Run extended e2e tests on a PR label Oct 20, 2025
@vercel
Copy link
Copy Markdown

vercel bot commented Oct 20, 2025

Deployment failed with the following error:

Failed to create deployment for team_QNIQyH5DJlqUjeCckcCcBEjE in project prj_MRaMO31eFIkY61SBqqPDR2Ojy8qP: FetchError: request to https://76.76.21.112/v13/now/deployments?ownerId=team_QNIQyH5DJlqUjeCckcCcBEjE&projectId=prj_MRaMO31eFIkY61SBqqPDR2Ojy8qP&skipAutoDetectionConfirmation=1&teamId=team_QNIQyH5DJlqUjeCckcCcBEjE&traceCarrier=%7B%22ot-baggage-webhookAt%22%3A%221760990479324%22%2C%22ot-baggage-senderUsername%22%3A%22gh.etrepum%22%2C%22baggage%22%3A%22webhookAt%3D1760990479324%2CsenderUsername%3Dgh.etrepum%22%2C%22x-datadog-trace-id%22%3A%225560496970608293192%22%2C%22x-datadog-parent-id%22%3A%228719040800804805966%22%2C%22x-datadog-sampling-priority%22%3A%222%22%2C%22x-datadog-tags%22%3A%22_dd.p.tid%3D68f6950f00000000%2C_dd.p.dm%3D-3%22%2C%22traceparent%22%3A%2200-68f6950f000000004d2ada88b3be3548-79004169b21b9d4e-01%22%2C%22tracestate%22%3A%22dd%3Dt.tid%3A68f6950f00000000%3Bt.dm%3A-3%3Bs%3A2%3Bp%3A79004169b21b9d4e%22%7D failed, reason: socket hang up

@vercel
Copy link
Copy Markdown

vercel bot commented Oct 20, 2025

Deployment failed with the following error:

Failed to create deployment for team_QNIQyH5DJlqUjeCckcCcBEjE in project prj_ea82vLj684XzSRdeO7JSd0QNkaws: FetchError: request to https://76.76.21.112/v13/now/deployments?ownerId=team_QNIQyH5DJlqUjeCckcCcBEjE&projectId=prj_ea82vLj684XzSRdeO7JSd0QNkaws&skipAutoDetectionConfirmation=1&teamId=team_QNIQyH5DJlqUjeCckcCcBEjE&traceCarrier=%7B%22ot-baggage-webhookAt%22%3A%221760990479324%22%2C%22ot-baggage-senderUsername%22%3A%22gh.etrepum%22%2C%22baggage%22%3A%22webhookAt%3D1760990479324%2CsenderUsername%3Dgh.etrepum%22%2C%22x-datadog-trace-id%22%3A%225560496970608293192%22%2C%22x-datadog-parent-id%22%3A%223961260909785001166%22%2C%22x-datadog-sampling-priority%22%3A%222%22%2C%22x-datadog-tags%22%3A%22_dd.p.tid%3D68f6950f00000000%2C_dd.p.dm%3D-3%22%2C%22traceparent%22%3A%2200-68f6950f000000004d2ada88b3be3548-36f939cf4e602cce-01%22%2C%22tracestate%22%3A%22dd%3Dt.tid%3A68f6950f00000000%3Bt.dm%3A-3%3Bs%3A2%3Bp%3A36f939cf4e602cce%22%7D failed, reason: socket hang up

@etrepum etrepum changed the title [lexical-link][lexical-code-shiki] Feature: Implement mergeConfig for LinkExtension and flatten config for CodeHighlighterShikiExtension [lexical-link][lexical-code-shiki][examples] Feature: Implement mergeConfig for LinkExtension and flatten config for CodeHighlighterShikiExtension Oct 21, 2025
@etrepum etrepum added this pull request to the merge queue Oct 21, 2025
Merged via the queue into facebook:main with commit d56abbb Oct 21, 2025
39 checks passed
This was referenced Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants