[lexical-extension] Feature: Allow nodes config to be deferred for circular dependency reasons#7930
Merged
etrepum merged 2 commits intofacebook:mainfrom Oct 18, 2025
Merged
Conversation
…rcular dependency reasons
|
The latest updates on your projects. Learn more about Vercel for GitHub.
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
ivailop7
approved these changes
Oct 18, 2025
This was referenced Oct 27, 2025
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In some bundler configurations, if there is a cyclic dependency between an extension and a node it configures, and they are in separate modules, there can be a runtime error because the bundler can't figure out how to define both the class and the extension.
In ESM with modern bundlers this typically isn't a problem.
See also discord thread
Test plan
New unit tests (and type check)