[lexical-markdown] Bug Fix: Prevent Markdown links with empty string link text from being automatically removed#7923
Conversation
|
Hi @adambolcsfoldi! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
A CommonMark Spec compliant but ultimately less useful fix was discussed and rejected here: #7919 |
|
You will need to accept the CLA before merging your PR can be considered. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Done! Sorry for the delay. |
…link text from being automatically removed
94f1aa7 to
a082334
Compare
|
No need to rebase or update unless there's a conflict, that just slows things down (CI has to run again) |
Description
Currently any markdown link where the link text is an empty string, e.g.
[](https://lexical.dev), will be automatically removed.With this pull request, the link persists allowing for further editing.
Test plan
Before
Before.Link.disappears.mov
After
After.Link.stays.mov