[lexical-yjs][lexical-react] Feature: commands for diffing two yjs snapshots in collab v2#7903
Merged
etrepum merged 2 commits intofacebook:mainfrom Oct 6, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
etrepum
approved these changes
Oct 6, 2025
Collaborator
etrepum
left a comment
There was a problem hiding this comment.
Wow, this is a really great demo of collab v2! I didn't have a super thorough look at all of the details but it seems very isolated to collab v2
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extends the collab v2 sync logic to add support for comparing two versions (Yjs snapshots) of a Lexical document. Determining what text has been added/removed is handled by Yjs'
YText.toDelta. For non-text nodes, I've adapted the logic from they-prosemirrorbinding.Two new commands are defined in
@lexical/yjswith handlers implemented in@lexical/react. I've also added a basic plugin in the playground for adding snapshots and comparing the latest editor state with said snapshots.Test plan
Added unit tests to cover the commands handled in
@lexical/react. Demo of the playground code:lexical-version-diff.mp4