Skip to content

[lexical-rich-text] Bug fix: up/down arrows for node selection#7902

Merged
etrepum merged 1 commit intofacebook:mainfrom
fantactuka:prevent-default-on-node-up-down
Oct 3, 2025
Merged

[lexical-rich-text] Bug fix: up/down arrows for node selection#7902
etrepum merged 1 commit intofacebook:mainfrom
fantactuka:prevent-default-on-node-up-down

Conversation

@fantactuka
Copy link
Copy Markdown
Collaborator

@fantactuka fantactuka commented Oct 3, 2025

Description

For whatever reason we didn’t have preventDefault for the up/down arrows for node selection. As a result, the caret jumps two lines when exiting a decorator.

Test plan

Insert decorator (easier to spot with block level decorator, like Youtube node)

Before

CleanShot.2025-10-03.at.16.48.08.mp4

After

CleanShot.2025-10-03.at.16.47.44.mp4

@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Oct 3, 2025

Hi @fantactuka!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@vercel
Copy link
Copy Markdown

vercel bot commented Oct 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
lexical Ready Ready Preview Comment Oct 3, 2025 2:51pm
lexical-playground Ready Ready Preview Comment Oct 3, 2025 2:51pm

@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Oct 3, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 3, 2025
@etrepum etrepum added this pull request to the merge queue Oct 3, 2025
Merged via the queue into facebook:main with commit 2414b97 Oct 3, 2025
40 checks passed
@etrepum etrepum mentioned this pull request Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants