[lexical-markdown] Bug Fix: Ensure First Match is Used in importTextMatchTransformer#7890
Merged
etrepum merged 2 commits intofacebook:mainfrom Sep 30, 2025
Merged
[lexical-markdown] Bug Fix: Ensure First Match is Used in importTextMatchTransformer#7890etrepum merged 2 commits intofacebook:mainfrom
importTextMatchTransformer#7890etrepum merged 2 commits intofacebook:mainfrom
Conversation
Ensure we use the first match if there are multiple on a line (when "outermost" is ambiguous), rather than just the match from the first transformer that ran on the line. This prevents cases where there is a `TextFormatTransformer` match in an earlier `TextMatchTransformer`. The `TextFormatTransformer` will segment the earlier `TextMatchTransformer` so that it is never parsed correct. See added test for an example that failed before this fix (the link would not be parsed and the raw link markdown was present in the final output).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
etrepum
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ensure we use the first match if there are multiple on a line (when "outermost" is ambiguous), rather than just the match from the first transformer that ran on the line.
This prevents cases where there is a
TextFormatTransformermatch in an earlierTextMatchTransformer. TheTextFormatTransformerwill segment the earlierTextMatchTransformerso that it is never parsed correct. See added test for an example that failed before this fix (the link would not be parsed and the raw link markdown was present in the final output).Test plan
Before
Added test failed
After
Added test passes