[lexical] Chore: Change TabNode.setTextContent invariant to devInvariant#7855
Merged
etrepum merged 2 commits intofacebook:mainfrom Sep 24, 2025
Merged
[lexical] Chore: Change TabNode.setTextContent invariant to devInvariant#7855etrepum merged 2 commits intofacebook:mainfrom
etrepum merged 2 commits intofacebook:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
etrepum
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, if the
setTextContentmethod onTabNodeis called with text that is not"\t"or"", it throws an error even in production. We had an issue where because we were using an older version of Lexical, some users' documents got into a state where theirTabNodes had non-tab text content which got synced to the Y.Doc. And then when we upgraded to 0.32.1, where the invariant was added, those users' document weren't syncing correctly because the Yjs hook would recreate the TabNode and try to set the non-tab text content which then throws an error.This PR changes the invariant to a devInvariant so that it only errors in development and only warns in production.