[lexical-react] Bug Fix: Include react-error-boundary and @floating-ui/react in WWW bundle#7852
Merged
etrepum merged 1 commit intofacebook:mainfrom Sep 23, 2025
Merged
Conversation
… ignore "use client" warnings
zurfyx
approved these changes
Sep 23, 2025
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
react-error-boundary and @floating-ui/react are external in OSS but should be bundled in WWW. This bundles them in that environment, and ignores any "use client" warnings.
Test plan
Can only be reproduced in the www build at Meta, but
npm run build-wwwworks without warning and you can confirm that it does not use an external import when inspecting the build artifacts (e.g.packages/lexical-react/dist/LexicalErrorBoundary.dev.js)