[lexical-playground] Bug Fix: Table add-row button no longer hides horizontal scroll#7847
[lexical-playground] Bug Fix: Table add-row button no longer hides horizontal scroll#7847etrepum merged 10 commits intofacebook:mainfrom niikkhilsharma:table-horizontal-scroll
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Hi @niikkhilsharma! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
closing this request due to CLA issues, I'll reopen it again. |
|
Re-opening the pull request after signing the Meta CLA |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
The screenshot that I gave is from window 11 Dell Laptop on brave browser. |
|
Hi @etrepum |
|
In your last comment you mentioned that there's more work to do so it renders appropriately on more platforms, but it doesn't look like you've done that yet |
|
@etrepum Kindly provide a review. All the fix has been implemented. |
|
Relax, it will get merged when there is time for a maintainer to take another look. This is not the highest priority PR for the project, we are in the middle of a release. |
|
You also don’t have to keep updating the branch unless there’s a conflict to resolve |
etrepum
left a comment
There was a problem hiding this comment.
Let's go ahead and simplify this, we don't need to add experimental chrome-specific platform detection code if we also have the fallback
packages/lexical-playground/src/plugins/TableHoverActionsPlugin/index.tsx
Outdated
Show resolved
Hide resolved
packages/lexical-playground/src/plugins/TableHoverActionsPlugin/index.tsx
Outdated
Show resolved
Hide resolved
|
I'll take a quick look after the tests run again and will approve and merge assuming they are passing and the result looks good. |



Current Behavior: The table add-row button appears on hover and covers the horizontal scrollbar when tables have many columns, making it impossible to scroll horizontally using the mouse. This creates a poor user experience when working with wide tables that require horizontal scrolling.
Changes in this PR:
Closes #7751
Test plan
Before
After
The solution looks like this :