[lexical-playground] Chore: remove InlineImageNode and InlineImagePlugun#7839
Merged
ivailop7 merged 1 commit intofacebook:mainfrom Sep 21, 2025
Merged
[lexical-playground] Chore: remove InlineImageNode and InlineImagePlugun#7839ivailop7 merged 1 commit intofacebook:mainfrom
ivailop7 merged 1 commit intofacebook:mainfrom
Conversation
…gin, seems redundant since ImageNode is almost exactly the same
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ivailop7
approved these changes
Sep 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
InlineImageNode and InlineImagePlugin are almost the same as ImageNode and ImagesPlugin. Only one e2e test used it.
As far as I can tell the only observable differences other than the support for css float (which could just be another property on ImageNode like the
positionproperty that was on InlineImageNode) when using the node is that ImageNode uses aspan > div > imgand InlineImageNode uses aspan > span > img. Arguably InlineImageNode's approach is more correct but ImageNode has been more maintained and more tests depend on it.Closes #5474
Test plan
All e2e and unit tests pass without InlineImageNode (only one test had to change)