[lexical] Chore: Improve error message when a node is registered from a foreign lexical module#7821
Merged
etrepum merged 2 commits intofacebook:mainfrom Sep 17, 2025
Merged
Conversation
… a foreign lexical module
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ivailop7
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
People can get themselves into scenarios where multiple versions of lexical are on the same page. We have some detection for this already with editors, but it doesn't get caught when an editor is configured with nodes that subclass nodes from some other version of lexical. This adds an additional check and provides a detailed error message for that scenario.
Closes #7819
Test plan
Unit test to verify that an error happens in this sort of case.
FakeLexicalNode (type fake-node) does not subclass LexicalNode from the lexical package used by this editor (version 0.35.0+git). All lexical and @lexical/* packages used by an editor must have identical versions. If you suspect the version does match, then the problem may be caused by multiple copies of the same lexical module (e.g. both esm and cjs, or included directly in multiple entrypoints).