Skip to content

[lexical-history] Add Missing Argument for DispatchCommand in Undo/Redo Docs Example#7795

Merged
etrepum merged 1 commit intofacebook:mainfrom
lithika-damnod:docs/lexical-history-edits
Sep 4, 2025
Merged

[lexical-history] Add Missing Argument for DispatchCommand in Undo/Redo Docs Example#7795
etrepum merged 1 commit intofacebook:mainfrom
lithika-damnod:docs/lexical-history-edits

Conversation

@lithika-damnod
Copy link
Copy Markdown
Contributor

@lithika-damnod lithika-damnod commented Sep 4, 2025

Context

This PR fixes a minor issue in the Lexical History undo/redo documentation example. The previous example was missing a required argument for dispatchCommand, which caused a TypeScript error

onClick={() => editor.dispatchCommand(UNDO_COMMAND)}
Expected 2 arguments, but got 1.ts(2554)
LexicalEditor.d.ts(513, 79): An argument for 'payload' was not provided.

Changes

The example has been updated to include the missing argument payload as undefined

onClick={() => editor.dispatchCommand(UNDO_COMMAND, undefined)}

Checklist

  • Documentation updated to reflect the required argument
  • Example code verified and works correctly in TypeScript
  • No functional changes introduced

@vercel
Copy link
Copy Markdown

vercel bot commented Sep 4, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
lexical Ready Ready Preview Comment Sep 4, 2025 8:21am
lexical-playground Ready Ready Preview Comment Sep 4, 2025 8:21am

@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Sep 4, 2025

Hi @lithika-damnod!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 4, 2025
@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Sep 4, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

etrepum
etrepum approved these changes Sep 4, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@etrepum etrepum added this pull request to the merge queue Sep 4, 2025
Merged via the queue into facebook:main with commit f9465a7 Sep 4, 2025
38 checks passed
@etrepum etrepum mentioned this pull request Sep 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etrepum etrepum etrepum approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm

@potatowagon potatowagon Awaiting requested review from potatowagon potatowagon is a code owner

@takuyakanbr takuyakanbr Awaiting requested review from takuyakanbr takuyakanbr is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lithika-damnod @etrepum