[lexical-react] Fix the context menu event listener element#7778
Merged
etrepum merged 2 commits intofacebook:mainfrom Aug 26, 2025
Merged
[lexical-react] Fix the context menu event listener element#7778etrepum merged 2 commits intofacebook:mainfrom
etrepum merged 2 commits intofacebook:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
etrepum
reviewed
Aug 26, 2025
Comment on lines
+251
to
+256
| const editorElement = editor.getRootElement(); | ||
| if (editorElement) { | ||
| editorElement.addEventListener('contextmenu', onContextMenu); | ||
| return () => | ||
| editorElement.removeEventListener('contextmenu', onContextMenu); | ||
| } |
Collaborator
There was a problem hiding this comment.
this isn't coherent if the root element ever changes for whatever reason, this should use a RootListener one way or another (either outside with state or inside here)
etrepum
approved these changes
Aug 26, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #7777