[lexical] Bug Fix: Correct exit direction from decorator nodes in RTL#7772
Merged
etrepum merged 6 commits intofacebook:mainfrom Aug 29, 2025
Merged
[lexical] Bug Fix: Correct exit direction from decorator nodes in RTL#7772etrepum merged 6 commits intofacebook:mainfrom
etrepum merged 6 commits intofacebook:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
Switching to draft because tests are not working yet |
etrepum
reviewed
Aug 26, 2025
Collaborator
etrepum
left a comment
There was a problem hiding this comment.
It looks like there are some test failures with Firefox
Contributor
Author
|
I set the test to skip on Firefox, but there's another bug (that's unmodified by the changes) in Firefox where selection can't be after the DateTime component if it's at the end of an RTL paragraph. Opened an issue for this in #7783. |
etrepum
approved these changes
Aug 29, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This updates the right/left key arrow handlers to correct whether the previous/next node should be selected, for RTL scenarios.
Closes #7771.
Closes #7775.
Test plan
Added a test for this.
Before
Screen.Recording.2025-08-23.at.19.37.13.mov
After
Screen.Recording.2025-08-23.at.20.05.40.mov