[Chore] Update flow suppressions to use error code#7770
Merged
takuyakanbr merged 4 commits intofacebook:mainfrom Aug 25, 2025
SamChou19815:SamChou19815-patch-1
Merged
[Chore] Update flow suppressions to use error code#7770takuyakanbr merged 4 commits intofacebook:mainfrom SamChou19815:SamChou19815-patch-1
takuyakanbr merged 4 commits intofacebook:mainfrom
SamChou19815:SamChou19815-patch-1
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
etrepum
reviewed
Aug 22, 2025
| declare export class AutoLinkNode extends LinkNode { | ||
| static getType(): string; | ||
| // $FlowFixMe clone method inheritance | ||
| // $FlowFixMe[incompatible-type] clone method inheritance |
Collaborator
There was a problem hiding this comment.
Cannot extend `LinkNode` [1] with `AutoLinkNode` because `AutoLinkNode` [2] is incompatible with `LinkNode` [3] in the
first parameter of property `clone`. [incompatible-extend]
Contributor
Author
There was a problem hiding this comment.
incompatible-type is the error code on latest version of flow with experimental.error_code_migration=new (and will be the default in the next version), which is what's used internally.
Revert the change for now, since the version used in the repo is too old. I will let the maintainer deal with this.
takuyakanbr
approved these changes
Aug 25, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Flow will ban codeless suppressions soon. This PR adds error codes to a few codeless suppressions in lexical.
Test plan
flow