[lexical-examples] Bug Fix: missing dependency @lexical/utils at examples/react-rich-collab#7743
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @debuggingfuture! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
The examples are not part of the build toolchain so these sorts of things can fall through the cracks |
|
There's also a bit of a bootstrapping issue with the package-lock files for the examples because they can't be updated (in any conventional way) until after the new version is published to npm |
Description
Expected vs Actual
npm i && npm run devrun out of the boxRoot Cause & Changes
package-lock.jsonis outdated, adding@lexical/utilsinpackage.jsonandnpm iresolves the issuepackage-lock.json. Shall we bump all of them & runnpm iat build process everytime?Test plan
After
npm i && npm run devable to start