[lexical-react] Bug Fix: prevent race condition in CollaborationPlugin during rapid mount/unmount cycles#7723
Merged
etrepum merged 1 commit intofacebook:mainfrom Jul 24, 2025
Merged
Conversation
…n during rapid mount/unmount cycles (facebook#7722)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
etrepum
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fix resolves a race condition by ensuring the Yjs document reference is captured after the provider is initialized, rather than during the component's render function.
Before: The doc state was initialized with
yjsDocMap.get(id)during the new component's render phase, which could capture a stale document reference because the old component instance's cleanup may not have executed yet.After: The doc state is now set within the provider useEffect, ensuring it always references the fresh document that corresponds to the newly created provider. By doing this we guarantee that:
This prevents the race condition where the new component's render function would capture a document reference before the old component's cleanup could run
docMap.delete(id), ensuring the binding's observer is always attached to the active Yjs document that's receiving server updates.Closes #7722