Skip to content

[lexical] Bug Fix: call $validatePoint on resolvedFocusPoint#7715

Closed
vchirikov wants to merge 1 commit intofacebook:mainfrom
vchirikov:fix
Closed

[lexical] Bug Fix: call $validatePoint on resolvedFocusPoint#7715
vchirikov wants to merge 1 commit intofacebook:mainfrom
vchirikov:fix

Conversation

@vchirikov
Copy link
Copy Markdown

@vchirikov vchirikov commented Jul 22, 2025

Description

Looks like the original author want to call $validatePoint on resolvedAnchorPoint AND resolvedFocusPoint, but accidentally call it only on resolvedAnchorPoint twice.

@vercel
Copy link
Copy Markdown

vercel bot commented Jul 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2025 10:11am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2025 10:11am

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jul 22, 2025

Hi @vchirikov!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jul 22, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 22, 2025
@ivailop7 ivailop7 added the extended-tests Run extended e2e tests on a PR label Jul 22, 2025
@etrepum
Copy link
Copy Markdown
Collaborator

etrepum commented Jul 22, 2025

It looks like this has probably found a bug given the amount of tests that are failing

@etrepum etrepum mentioned this pull request Jul 24, 2025
Merged
@vchirikov vchirikov deleted the fix branch July 25, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivailop7 ivailop7 ivailop7 approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz

@Sahejkm Sahejkm Awaiting requested review from Sahejkm

@potatowagon potatowagon Awaiting requested review from potatowagon potatowagon is a code owner

@lilshady lilshady Awaiting requested review from lilshady

@takuyakanbr takuyakanbr Awaiting requested review from takuyakanbr takuyakanbr is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vchirikov @facebook-github-bot @etrepum @ivailop7