[lexical-table][lexical-playground] Fix: Insertion of multiple rows#6963
Merged
etrepum merged 4 commits intofacebook:mainfrom Dec 14, 2024
Merged
[lexical-table][lexical-playground] Fix: Insertion of multiple rows#6963etrepum merged 4 commits intofacebook:mainfrom
etrepum merged 4 commits intofacebook:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
etrepum
previously approved these changes
Dec 13, 2024
Collaborator
etrepum
left a comment
There was a problem hiding this comment.
This looks good to me, nice job! Will merge assuming the extended test suite still looks good.
etrepum
reviewed
Dec 14, 2024
Collaborator
etrepum
left a comment
There was a problem hiding this comment.
This new test either needs to be skipped with isCollab, or it needs to be fixed for isCollab. The selection classes won't appear on the right frame because that's not the editor they are selected in, so a separate HTML document needs to be specified for the right frame.
etrepum
approved these changes
Dec 14, 2024
|
When is the release planned that includes above change? |
Collaborator
|
Releases happen about once a month. If you need it sooner, you can use a nightly release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes in this pull request
When inserting multiple rows only one row was being added and also the position of the newly added row was sometimes in the middle of the rows.
Fixed the
insertTableRow_Experimentalfunction to handle the insertAfter and insertBefore row based on the maximum and minimum value of anchor and focus row.Closes #6933
Test plan
Before
Insert relevant screenshots/recordings/automated-tests
multiple_rows_before.1.mp4
After
multiple_rows.1.mp4