Skip to content

[lexical-list] Bug Fix: Ensure new paragraph node retains selection styling when exiting list#6917

Merged
etrepum merged 8 commits intofacebook:mainfrom
aleksandr-lapushkin:fix-paragraph-styling-on-list-exit
Dec 10, 2024
Merged

[lexical-list] Bug Fix: Ensure new paragraph node retains selection styling when exiting list#6917
etrepum merged 8 commits intofacebook:mainfrom
aleksandr-lapushkin:fix-paragraph-styling-on-list-exit

Conversation

@aleksandr-lapushkin
Copy link
Copy Markdown
Contributor

@aleksandr-lapushkin aleksandr-lapushkin commented Dec 6, 2024 •
edited
Loading

Description

  • Currently, when exiting a list by pressing enter multiple times, the selection style is lost
  • This PR aims to ensure that the current style is retained

Test plan

Before

  • Go to Playground
  • Insert a new list
  • Change text style, i.e. font, color or formatting
  • Write a few bullet points
  • Press enter twice to exit list
  • Write more text - this will no longer have the correct styles applied
Screen.Recording.2024-12-06.at.17.41.54.mov

After

  • Go to Playground
  • Insert a new list
  • Change text style, i.e. font, color or formatting
  • Write a few bullet points
  • Press enter twice to exit list
  • Write more text - this will be styled correctly
Screen.Recording.2024-12-06.at.17.41.15.mov

@vercel
Copy link
Copy Markdown

vercel bot commented Dec 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 5:12pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 5:12pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 6, 2024
@aleksandr-lapushkin
Copy link
Copy Markdown
Contributor Author

aleksandr-lapushkin commented Dec 6, 2024

Honestly not sure if there's a better way to do this, but seemed reasonable enough 🤷🏻

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 6, 2024 •
edited
Loading

size-limit report 📦

Path Size
lexical - cjs 31.18 KB (0%)
lexical - esm 31 KB (0%)
@lexical/rich-text - cjs 40.15 KB (0%)
@lexical/rich-text - esm 32.83 KB (0%)
@lexical/plain-text - cjs 38.79 KB (0%)
@lexical/plain-text - esm 30.15 KB (0%)
@lexical/react - cjs 42 KB (0%)
@lexical/react - esm 34.23 KB (0%)

etrepum
etrepum reviewed Dec 6, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if there was a unit and/or e2e test to show that this has the expected result

@etrepum etrepum added the extended-tests Run extended e2e tests on a PR label Dec 6, 2024
@aleksandr-lapushkin
Copy link
Copy Markdown
Contributor Author

aleksandr-lapushkin commented Dec 9, 2024 •
edited
Loading

It would be great if there was a unit and/or e2e test to show that this has the expected result

Sure thing! Added an e2e test. Verified that test fails without these changes.

@etrepum etrepum added this pull request to the merge queue Dec 10, 2024
Merged via the queue into facebook:main with commit 3ba0705 Dec 10, 2024
@etrepum etrepum mentioned this pull request Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etrepum etrepum etrepum approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm

@potatowagon potatowagon Awaiting requested review from potatowagon potatowagon is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aleksandr-lapushkin @etrepum @facebook-github-bot