[lexical] Feature: customElements judgment when destroyNode#6587
Closed
yaojiu19 wants to merge 1 commit intofacebook:mainfrom
yaojiu19:feature/destroy-customElements-child
Closed
[lexical] Feature: customElements judgment when destroyNode#6587yaojiu19 wants to merge 1 commit intofacebook:mainfrom yaojiu19:feature/destroy-customElements-child
yaojiu19 wants to merge 1 commit intofacebook:mainfrom
yaojiu19:feature/destroy-customElements-child
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
Collaborator
|
It's not supported to have DOM nodes in the editor that are unmanaged by Lexical except in a DecoratorNode. If this feature were to be considered it would need tests and documentation, it's likely that this has other problems that you haven't noticed yet. |
Author
|
In my project, By controlling the node importDOM and customElement event rewrite, can ensure correct parsing and rendering |
Author
|
if the node DOM not's customElement, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I define customElement, it include multiple elements,like:
create node, like:
now, cant destroyNode TableNode's children Element.
because TableNode's children Element's parentNode not equal to the customElement
Test plan
Before
if (dom.parentNode === parentDOM) {
parentDOM.removeChild(dom);
}
After
modification the customElement's children and add isCustomElementChild judgment