Skip to content

fix(lexical/createEditor): avoid implicit any type#5889

Merged
StyleT merged 1 commit intofacebook:mainfrom
jason89521:type/createEditor/prevent-implicit-any
Apr 16, 2024
Merged

fix(lexical/createEditor): avoid implicit any type#5889
StyleT merged 1 commit intofacebook:mainfrom
jason89521:type/createEditor/prevent-implicit-any

Conversation

@jason89521
Copy link
Copy Markdown
Contributor

Why

We should avoid implicit any type because it may cause problems in the future.

What

Explicitly setup the type of the replace and replaceWithKlass when creating them.

Additional information

before
image

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 3:56am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 3:56am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 15, 2024
@jason89521 jason89521 marked this pull request as ready for review April 15, 2024 04:57
Copy link
Copy Markdown
Contributor

@potatowagon potatowagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@StyleT
Copy link
Copy Markdown
Contributor

StyleT commented Apr 16, 2024

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants