Remove unnecessary type assertions from useReport.ts#5884
Merged
StyleT merged 2 commits intofacebook:mainfrom Apr 16, 2024
Merged
Remove unnecessary type assertions from useReport.ts#5884StyleT merged 2 commits intofacebook:mainfrom
StyleT merged 2 commits intofacebook:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
etrepum
reviewed
Apr 13, 2024
| if (timer !== null) { | ||
| clearTimeout(timer.current as ReturnType<typeof setTimeout>); | ||
| if (timer.current !== null) { | ||
| clearTimeout(timer.current); |
Collaborator
There was a problem hiding this comment.
While you're in here, semantically it would make sense to also set timer.current = null; after clearing, although the clearTimeout API doesn't really care if it's called with invalid ids
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this is better for type-safety