Skip to content

Replace async arrow with function#5870

Merged
zurfyx merged 1 commit intomainfrom
asyncbreak
Apr 11, 2024
Merged

Replace async arrow with function#5870
zurfyx merged 1 commit intomainfrom
asyncbreak

Conversation

@zurfyx
Copy link
Copy Markdown
Member

@zurfyx zurfyx commented Apr 11, 2024

Intern isn't happy with async arrows, we should follow up with a lint rule like we did with coalescent.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 11, 2024
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 0:23am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 0:23am

@github-actions
Copy link
Copy Markdown

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.95 KB (-0.02% 🔽) 539 ms (-0.02% 🔽) 12 ms (+18.16% 🔺) 551 ms
packages/lexical-rich-text/dist/LexicalRichText.js 39.37 KB (-0.01% 🔽) 788 ms (-0.01% 🔽) 34 ms (+11.56% 🔺) 822 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 39.34 KB (-0.02% 🔽) 787 ms (-0.02% 🔽) 31 ms (-17.73% 🔽) 818 ms

@zurfyx zurfyx merged commit f85a177 into main Apr 11, 2024
@zurfyx zurfyx deleted the asyncbreak branch April 11, 2024 00:37
Copy link
Copy Markdown
Contributor

@Sahejkm Sahejkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acywatson acywatson mentioned this pull request Apr 16, 2024
@agriffis
Copy link
Copy Markdown
Contributor

What's intern?

@acywatson
Copy link
Copy Markdown
Contributor

What's intern?

ah it's just one of the environments Lexical runs in at Meta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants