Fix bug with typeahead positioning#5859
Merged
thegreatercurve merged 1 commit intomainfrom Apr 9, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
acywatson
approved these changes
Apr 9, 2024
Collaborator
|
That's unfortunate, because my change fixed the context menu being rendered off screen when the playground was scrolled. The context menu is now broken again when the page is scrolled. So I guess we can't have it both ways 🤷🏻♂️ |
Contributor
Author
I'll try to set aside some time and look into abstracting out |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added in #5791 this is causing some menus for the typeahead plugin to be rendered offscreen.