Skip to content

Playground - Clear Format button fix#5849

Merged
ivailop7 merged 4 commits intofacebook:mainfrom
ManuelOjedaWz:playground-clear-format-fix
Apr 8, 2024
Merged

Playground - Clear Format button fix#5849
ivailop7 merged 4 commits intofacebook:mainfrom
ManuelOjedaWz:playground-clear-format-fix

Conversation

@ManuelOjedaWz
Copy link
Copy Markdown
Contributor

This PR fixes an issue found in the Playground. When you select a portion of a selected text with the format applied, it could wrongly remove the format to another portion of the sentence with the same format applied.

Reference:

Screen.Recording.2024-04-08.at.11.07.17.mov

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 9:06pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 9:06pm

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Hi @ManuelOjedaWz!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@ivailop7
Copy link
Copy Markdown
Collaborator

ivailop7 commented Apr 8, 2024

@ManuelOjedaWz Could you sign the CLA, rest looks good.

@ManuelOjedaWz
Copy link
Copy Markdown
Contributor Author

@ivailop7 I've already signed the CLA but is not being detected here

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 8, 2024
@ivailop7 ivailop7 merged commit 340d448 into facebook:main Apr 8, 2024
@acywatson acywatson mentioned this pull request Apr 16, 2024
@i-tengfei
Copy link
Copy Markdown
Contributor

These changes seem to have caused another bug, and it is now impossible to clear the formatting of multi-line text.

@ivailop7
Copy link
Copy Markdown
Collaborator

Can you raise an issue, to have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants