Skip to content

Fix issue with removing selectionchange correctly#5848

Merged
thegreatercurve merged 2 commits intomainfrom
bug/selection-bug-2
Apr 8, 2024
Merged

Fix issue with removing selectionchange correctly#5848
thegreatercurve merged 2 commits intomainfrom
bug/selection-bug-2

Conversation

@thegreatercurve
Copy link
Copy Markdown
Contributor

@thegreatercurve thegreatercurve commented Apr 8, 2024

The latter check should actually be for '0'.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 2:37pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 2:37pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 8, 2024
@thegreatercurve thegreatercurve marked this pull request as ready for review April 8, 2024 14:35
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.95 KB (0%) 539 ms (0%) 106 ms (+307.3% 🔺) 645 ms
packages/lexical-rich-text/dist/LexicalRichText.js 39.37 KB (+0.02% 🔺) 788 ms (+0.02% 🔺) 122 ms (+33.92% 🔺) 910 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 39.34 KB (+0.01% 🔺) 787 ms (+0.01% 🔺) 100 ms (+39.15% 🔺) 887 ms

@thegreatercurve thegreatercurve merged commit d306095 into main Apr 8, 2024
@thegreatercurve thegreatercurve changed the title Fix issue with removeing selectionchange correctly Fix issue with removing selectionchange correctly Apr 8, 2024
@thegreatercurve thegreatercurve deleted the bug/selection-bug-2 branch April 8, 2024 14:55
@acywatson acywatson mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants