Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zurfyx
approved these changes
Apr 8, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #5809 I added some gfm table syntax which docusaurus 2 doesn't render by default. I tried including the remark-gfm plugin with docusaurus 2 but it didn't work for esm reasons (my villain arc) so here is an upgrade to docusaurus 3 where it does work (and remark-gfm is enabled by default).
I did have to change broken links from throw to warn mostly because there are broken links and it just wasn't catching them before. I've noticed at least one misspelling and otherwise a systemic problem is that typedoc labels must be
[a-z_][0-9a-z_]*but JavaScript and TypeScript names can have other characters, like our beloved$. typedoc seems perfectly happy to strip these from the labels it generates, but it doesn't do the same kind of normalization for something like{@link lexical!$getRoot}so it will generate an anchor#$getrootbut it should be#getroot. I'm looking into a workaround for this but that will likely take a little longer.