fix: webpack needs its own export condition#5833
Merged
ivailop7 merged 2 commits intofacebook:mainfrom Apr 5, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
You are amazing ! |
Collaborator
Author
|
It doesn't always feel that way after weeks of fixing one thing and breaking something else in the process 😅 At least everyone is nice here! |
acywatson
approved these changes
Apr 5, 2024
ivailop7
approved these changes
Apr 5, 2024
Collaborator
|
Seeing all these webpack-related issues, is a good reminder why everyone embraced vite and esbuild so fast. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Webpack (and SWC?) produce some truly inscrutable error messages when you provide it with ESM that uses top-level await. Unfortunately, it also prefers to load "node" condition code over "default". In order to support both node ESM imports and webpack at the same time we need to add a separate "webpack" condition at a higher priority than "node".
Related reading: https://webpack.js.org/guides/package-exports/#conditions-preprocessor-and-runtimes
🤦
Fix #5823