feat: export 'IS_' and 'CAN_*' environment constants from @lexical/utils#5831
Merged
acywatson merged 1 commit intofacebook:mainfrom Apr 5, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
acywatson
approved these changes
Apr 5, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exports all of the `IS_*` and `CAN_*` environment constants from @lexical/utils.
While browser detection isn't really the purview of Lexical, these constants (or copy-pasted equivalents) are often necessary when implementing lower level features or just working around browser quirks. I found them useful to copy when I was working on a project that blended the code from lexical/plain-text and lexical/rich-text, which I found easier to understand and maintain by creating an independent "registerCustomText" rather than picking one and overriding functionality with higher command priorities.
Resolves #5827