Skip to content

fix: Fix E2E tests in Safari (Webkit)#5672

Merged
ivailop7 merged 1 commit intofacebook:mainfrom
StyleT:feature/e2e_tests_fix
Mar 1, 2024
Merged

fix: Fix E2E tests in Safari (Webkit)#5672
ivailop7 merged 1 commit intofacebook:mainfrom
StyleT:feature/e2e_tests_fix

Conversation

@StyleT
Copy link
Copy Markdown
Contributor

@StyleT StyleT commented Feb 29, 2024 •
edited
Loading

Few root causes here:

  1. Caused by special handling for Webkit in tests. Apparently now it's fine to remove it
  2. Selection in Webkit still works somehow differently to other browsers but in tests that are not related to selection it's OK to remove this extra check as it brings not value but causes flakiness
  3. CDP session is only available in Chromium

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 1:37am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 1:37am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 29, 2024
@StyleT StyleT force-pushed the feature/e2e_tests_fix branch from 0921766 to dbd02e5 Compare February 29, 2024 22:29
@StyleT StyleT changed the title [WIP] fix: This fixes some E2E test in Safari (Webkit) [WIP] fix: This fixes some E2E tests in Safari (Webkit) Feb 29, 2024
@StyleT StyleT force-pushed the feature/e2e_tests_fix branch from dbd02e5 to 9f5ad21 Compare February 29, 2024 23:38
@StyleT StyleT force-pushed the feature/e2e_tests_fix branch from 9f5ad21 to a5fdc1f Compare February 29, 2024 23:50
@StyleT StyleT force-pushed the feature/e2e_tests_fix branch from a5fdc1f to e963dd9 Compare February 29, 2024 23:53
@StyleT StyleT force-pushed the feature/e2e_tests_fix branch from e963dd9 to c3ef466 Compare March 1, 2024 00:15
@StyleT StyleT force-pushed the feature/e2e_tests_fix branch from c3ef466 to edbcee7 Compare March 1, 2024 00:37
@StyleT StyleT mentioned this pull request Mar 1, 2024
Closed
@StyleT
fix: This fixes some E2E tests in Safari (Webkit)
1a726e0 
Few root causes here:
1. Caused by special handling for Webkit in tests. Apparently now it's fine to remove it
2. Selection in Webkit still works somehow differently to other browsers but in tests that are not related to selection it's OK to remove this extra check as it brings not value but causes flakiness
@StyleT StyleT force-pushed the feature/e2e_tests_fix branch from edbcee7 to 1a726e0 Compare March 1, 2024 01:34
@StyleT StyleT changed the title [WIP] fix: This fixes some E2E tests in Safari (Webkit) fix: Fix E2E tests in Safari (Webkit) Mar 1, 2024
@StyleT StyleT marked this pull request as ready for review March 1, 2024 01:51
ivailop7
ivailop7 approved these changes Mar 1, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ivailop7 ivailop7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic! Thank you vm!

@ivailop7 ivailop7 merged commit 9445ed2 into facebook:main Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivailop7 ivailop7 ivailop7 approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StyleT @ivailop7 @facebook-github-bot