Draft: Support nested blockquotes in markdown#4339
Draft: Support nested blockquotes in markdown#4339themagickoala wants to merge 1 commit intofacebook:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks for the PR! Few thoughs on it: |
|
@fantactuka that's the kind of solution I'm going for here. Markdown syntax has the capability to be sort of power user mode, where you can do a little more than you can with a toolbar. That's certainly how it works with our users anyway! I'm not sure the performance of my solution is up to scratch, this is mostly a proof of concept, I'd love to get some pointers though! I didn't want to make too many sweeping changes to the internals of the export/import, but it might end up being necessary to implement the kind of recursive support we might want? |
|
Closing this for the moment due to inactivity, and we're tracking this in a separate issue involving customising the behaviour beyond just markdown |
A requirement for our markdown needs is to support nested blockquotes. I've created this PR as a starting point to discuss a potential implementation. I'm sure there are things I've missed (@fantactuka mentioned the
$setBlocksTypepotentially not behaving as expected on Discord), but wanted to float this here so that you have the full context.Changes:
$convertToMarkdownString;exportTopLevelElementsmethod to pass transformers to the export prop to support the above;exportTopLevelElementsmethod to run text match transformers;