Skip to content

Add size limit report#3600

Merged
fantactuka merged 1 commit intomainfrom
size-limit
Dec 22, 2022
Merged

Add size limit report#3600
fantactuka merged 1 commit intomainfrom
size-limit

Conversation

@fantactuka
Copy link
Copy Markdown
Collaborator

@fantactuka fantactuka commented Dec 20, 2022

Adds PR size report for lexical core, plain and rich text packages

@vercel
Copy link
Copy Markdown

vercel bot commented Dec 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
lexical ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 20, 2022 at 3:18PM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 20, 2022 at 3:18PM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 20, 2022
@fantactuka
Copy link
Copy Markdown
Collaborator Author

fantactuka commented Dec 20, 2022

Looking into failed "size" GH action, and it seems like it tries to switch to main branch and run size limit as well which fails as we don't have it in main yet. So we probably will need to merge this PR to get proper size report

Copy link
Copy Markdown
Contributor

@acywatson acywatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get rid of the dangerJS dependency? I think it was attempting to serve the same purpose.

@fantactuka
Copy link
Copy Markdown
Collaborator Author

dangerJS

Don't see it anywhere

@fantactuka fantactuka merged commit 8da9bb2 into main Dec 22, 2022
@fantactuka fantactuka deleted the size-limit branch December 22, 2022 19:02
@trueadm trueadm mentioned this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants