Skip to content

docs: create astro docs website#592

Merged
Daniel15 merged 10 commits intofacebook:mainfrom
mohab-sameh:docs/astro-docs
Jul 5, 2024
Merged

docs: create astro docs website#592
Daniel15 merged 10 commits intofacebook:mainfrom
mohab-sameh:docs/astro-docs

Conversation

@mohab-sameh
Copy link
Collaborator

No description provided.

@vercel
Copy link

vercel bot commented Jul 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jscodeshift ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2024 1:58pm

Copy link
Member

@Daniel15 Daniel15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks pretty good. The content looks great! Just some minor comments inline.

Can you please switch to using Yarn v1 instead of npm, for consistency with jscodeshift itself? Delete the package-lock.json, use yarn install, and commit the yarn.lock file instead.

Please also ensure all files are formatted following the settings in .editorconfig, using two spaces for indentation.

@mohab-sameh
Copy link
Collaborator Author

@Daniel15 Will do. Thanks!

@Daniel15
Copy link
Member

Daniel15 commented Jul 5, 2024

Great! Let's go :D

@Daniel15 Daniel15 merged commit 5c403d8 into facebook:main Jul 5, 2024
@mohab-sameh mohab-sameh mentioned this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants