Improve handling of .gitignore files.#306
Merged
fkling merged 1 commit intofacebook:masterfrom Mar 6, 2019
amanda-mitchell:improve-gitignore-handling
Merged
Improve handling of .gitignore files.#306fkling merged 1 commit intofacebook:masterfrom amanda-mitchell:improve-gitignore-handling
fkling merged 1 commit intofacebook:masterfrom
amanda-mitchell:improve-gitignore-handling
Conversation
* Omit comments from list of patterns. * Support .gitignore files with \r\n linebreaks.
This was referenced Mar 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to use jscodeshift in a repo that had a .gitignore that used
\r\nas the newline character, and it crashed inside of snapdragon (used by minimatch) because all of the file globs had trailing\rs.This PR cleans up trailing
\rs and also prevents .gitignore comments from being treated as globs.